Conversation
AshishA26
force-pushed
the
add_in_classical_cv
branch
from
5da7a5e to
6bb42a3
Compare
achitaan
force-pushed
the
add_in_classical_cv
branch
from
67691e0 to
b1f0e49
Compare
There was a problem hiding this comment.
Me as a new member making an easy mistake:
top_left_x = boxes_list[0]
top_left_y = boxes_list[1]
bottom_right_x = boxes_list[2]
bottom_right_x = boxes_list[3]Add an explanation for the shape!
There was a problem hiding this comment.
Why are there so many fixtures doing the same work? I expect InputImageAndExpectedBoundingBoxes to already have the required information. Move this work into generate_detect_target_contour.py .
There was a problem hiding this comment.
I based a lot of my code on the ultralytics one so I thought this would be proper structure, should I do something else or just have it moved?
There was a problem hiding this comment.
image_and_time.ImageAndTime.create() should already be part of the generation that results in InputImageAndExpectedBoundingBoxes .
create_detections() is not necessary because it just holds the time data (which is thrown away). compare_detections() should take in just the bounding boxes.
There was a problem hiding this comment.
Pylint is part of the coding standard, so suppressing it needs to be justified. Can you explain:
- What exactly is causing this
- Why it's not possible to change the code so that it no longer warns on this
|
|
||
| (x, y), radius = cv2.minEnclosingCircle(contour) | ||
|
|
||
| enclosing_area = np.pi * (radius**2) |
| expected_blur: detections_and_time.DetectionsAndTime, | ||
| ) -> None: | ||
| """ | ||
| Run the detection for the blury cicular circle. |
There was a problem hiding this comment.
Spelling: for a single blurry circular landing pad.
Issues: detect_target_contour not detecting any contours(?)
Class -> Functions (Some sort of issue with detect_target)contour, extra unit tests added after)
…urs + Working Tests
achitaan
force-pushed
the
add_in_classical_cv
branch
from
03d95cb to
8ce749c
Compare
| # Create new object with actual detections | ||
| test_data = generate_detect_target_contour.InputImageAndTimeAndExpectedBoundingBoxes( | ||
| actual, | ||
| single_circle.bounding_box_list | ||
| ) | ||
| compare_detections(test_data) |
There was a problem hiding this comment.
No!
def compare_detections(actual: list[Detection], expected: np.ndarray) -> None:
...
# The test
...
assert actual is not None
compare_detections(actual.detections, single_circle.bounding_box_list)
# End of test no more code here in this test3 participants
Do not review. Waiting for tests.